chore: add tests for PHP 8.2, fix ci deprecations#49
Closed
Chris53897 wants to merge 1 commit intoclue:1.xfrom
Chris53897:feature/improve-ci
Closed
chore: add tests for PHP 8.2, fix ci deprecations#49Chris53897 wants to merge 1 commit intoclue:1.xfrom Chris53897:feature/improve-ci
Chris53897 wants to merge 1 commit intoclue:1.xfrom
Chris53897:feature/improve-ci
Conversation
Owner
|
@Chris53897 Thank you for looking into this and filing this PR! I can confirm the test suite currently fails due to outdated dependencies for legacy HHVM, so I've just filed #50 to update the test environment. All tests pass successfully again with the updated environment. |
Contributor
Author
|
Thanks @clue |
Contributor
|
@Chris53897 Just merged #50, test should be all green now. Thanks again for bringing this up 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests are failing on my fork.
No-Changes => ** **
The last run on this repo is more than a year old. I guess gitub changes somethig
Should be fixed in an seperated PR in my point of view.